-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for ControlDesigner.ControlDesignerAccessibleObject #12664
Open
MelonWang1
wants to merge
2
commits into
dotnet:main
Choose a base branch
from
MelonWang1:Add_unit_tests_for_ControlDesigner.ControlDesignerAccessibleObject
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add unit tests for ControlDesigner.ControlDesignerAccessibleObject #12664
MelonWang1
wants to merge
2
commits into
dotnet:main
from
MelonWang1:Add_unit_tests_for_ControlDesigner.ControlDesignerAccessibleObject
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12664 +/- ##
===================================================
+ Coverage 76.02394% 76.04056% +0.01662%
===================================================
Files 3180 3182 +2
Lines 639659 639752 +93
Branches 47216 47217 +1
===================================================
+ Hits 486294 486471 +177
+ Misses 149851 149763 -88
- Partials 3514 3518 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
ricardobossan
requested changes
Dec 20, 2024
...nitTests/System/Windows/Forms/Design/ControlDesigner.ControlDesignerAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...nitTests/System/Windows/Forms/Design/ControlDesigner.ControlDesignerAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...nitTests/System/Windows/Forms/Design/ControlDesigner.ControlDesignerAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
dotnet-policy-service
bot
added
the
📭 waiting-author-feedback
The team requires more information from the author
label
Dec 20, 2024
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
The team requires more information from the author
label
Dec 23, 2024
ricardobossan
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10773
Proposed changes
Add unit test ControlDesigner.ControlDesignerAccessibleObjectTests.cs for public properties and method of the ControlDesigner.ControlDesignerAccessibleObject.
Enable nullability in ControlDesigner.ControlDesignerAccessibleObjectTests.cs.
Microsoft Reviewers: Open in CodeFlow