-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing the renderMode to System when the StatusStrip was selected #12646
Open
LeafShi1
wants to merge
4
commits into
dotnet:main
Choose a base branch
from
LeafShi1:Fix_11450_Change_RenderMode_When_StatusStripItemWasSelected
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changing the renderMode to System when the StatusStrip was selected #12646
LeafShi1
wants to merge
4
commits into
dotnet:main
from
LeafShi1:Fix_11450_Change_RenderMode_When_StatusStripItemWasSelected
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12646 +/- ##
====================================================
- Coverage 97.03492% 76.02724% -21.00768%
====================================================
Files 1182 3181 +1999
Lines 354561 639676 +285115
Branches 5411 47216 +41805
====================================================
+ Hits 344048 486328 +142280
- Misses 9724 149820 +140096
- Partials 789 3528 +2739
Flags with carried forward coverage won't be shown. Click here to find out more. |
LeafShi1
added
the
waiting-review
This item is waiting on review by one or more members of team
label
Dec 17, 2024
Tanya-Solyanik
added
the
📭 waiting-author-feedback
The team requires more information from the author
label
Dec 18, 2024
Please investigate if the fix can be moved to the lower level rendering code |
Tanya-Solyanik
removed
the
waiting-review
This item is waiting on review by one or more members of team
label
Dec 18, 2024
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
The team requires more information from the author
label
Dec 26, 2024
LeafShi1
added
the
waiting-review
This item is waiting on review by one or more members of team
label
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12616
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
A white line in the dialog when using StatusStrip
After
No extra white line the dialog
The color contrast between the focus indicator and toolStripSplitButton1 is still sufficient
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow