Improve xml comments review 5th DRAFT #12148
Conversation
paul1956
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12148 +/- ##
===================================================
+ Coverage 76.03186% 76.22662% +0.19476%
===================================================
Files 3181 3189 +8
Lines 639670 643152 +3482
Branches 47215 47459 +244
===================================================
+ Hits 486353 490253 +3900
+ Misses 149797 149368 -429
- Partials 3520 3531 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
paul1956
changed the title
| ''' <exception cref="NotSupportedException">A folder name in the path contains a colon (:) or is in an invalid format.</exception> | ||
| ''' <exception cref="SecurityException">The user lacks necessary permissions to view the path.</exception> | ||
| ''' <exception cref="UnauthorizedAccessException">A destination file exists but cannot be accessed.</exception> | ||
| Public Sub CopyDirectory(sourceDirectoryName As String, destinationDirectoryName As String, overwrite As Boolean) |
There was a problem hiding this comment.
Perhaps this comment can reference docs for the SYstem.IO API via the inheritdocs tag?
There was a problem hiding this comment.
@Tanya-Solyanik i can fix comment but this is not ready to be reviewed (it should be DRAFT) as it includes all the other small PR’s not yet merged.
There was a problem hiding this comment.
I have updated the VB Runtime Proxy Comments to use inheritdoc cref=""
Sometimes I could point to System.IO other files I had to point to FileIO.FileSystem because VB is not always a thin layer over System.IO, in some causes Sub and Function are swapped, return types are different or System.IO does not have all the overloads that VB has plus other similar reasons. The complexity/size of the files has been drastically simplified.
This is still not ready to review.
Add missing tests and cleanup
…' into Shorten-long-inline-comments-Review-4th
Fix Upload logic to handle Web error 500
Correct a test
…Review-after-FixIssue#9807-3rd
…' into Shorten-long-inline-comments-Review-4th
…ML-Comments-Review-5th-DRAFT
…Review-after-FixIssue#9807-3rd
…' into Shorten-long-inline-comments-Review-4th
…ML-Comments-Review-5th-DRAFT
Addresses improved XML comment in #11984
Proposed changes
Customer Impact
Regression?
Risk
Microsoft Reviewers: Open in CodeFlow