Skip to content

Conversation

@nagilson
Copy link
Member

Resolves #2269
The old env variables may mess up our output parsing, so we should unset them or prevent color formatting in output. Please see #2269

One concern is whether TERM=dumb would cause other failures, but in general this is only meant to disable ansi scape codes (for color and formatting) which we dont want, and this is recommended to be set for scripting. https://linux.die.net/man/7/term

nagilson added 4 commits July 28, 2025 11:10
This may mess up our output parsing. Please see dotnet#2269,

One concern is whether TERM=dumb would cause other failures, but in general this is only meant to disable ansi scape codes (for color and formatting) which we dont want, and this is recommended to be set for scripting. https://linux.die.net/man/7/term
@nagilson nagilson requested a review from Copilot November 4, 2025 22:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds environment variable configurations to normalize command execution output by suppressing color codes and standardizing terminal behavior. The changes ensure consistent output parsing across different user environments.

  • Adds NO_COLOR, TERM, and GREP_OPTIONS environment variables to command execution options
  • Updates the environment variable logging list to include the new variables for debugging purposes

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
vscode-dotnet-runtime-library/src/Utils/CommandExecutor.ts Sets NO_COLOR='1', TERM='dumb', and GREP_OPTIONS=undefined for command execution to ensure clean, parseable output
vscode-dotnet-runtime-library/src/Utils/TypescriptUtilities.ts Adds GREP_OPTIONS and NO_COLOR to the list of environment variables logged for debugging

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GREP_OPTIONS Color settings cause shell output failure

1 participant