[main] Source code updates from dotnet/dotnet #1240
Merged
+15
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
|
SB leg failures are caused by an instance of dotnet/arcade-services#4739. This will be fixed once dotnet/dotnet#258 flows in. |
ViktorHofer
approved these changes
Apr 29, 2025
akoeplinger
reviewed
Apr 29, 2025
| @@ -17,7 +17,7 @@ | |||
| <MicrosoftNETCoreILAsmVersion>6.0.0-preview.6.21352.12</MicrosoftNETCoreILAsmVersion> | |||
| <MicrosoftNETCoreILDAsmVersion>6.0.0-preview.6.21352.12</MicrosoftNETCoreILDAsmVersion> | |||
There was a problem hiding this comment.
@ViktorHofer this version is out of sync with the one in Version.Details.xml and looks manually updated, should we remove it there?
There was a problem hiding this comment.
Isn't that version used by the repo build?
There was a problem hiding this comment.
Yes, we should make them the same
There was a problem hiding this comment.
OK this was already the case before the backflow changes. @MichaelSimons should those version get updated to something newer? A version closer to what the product uses with the PSB? Also, should there be toolset sub for it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Updated Dependencies