Explicitly fail if all deployment manifests are excluded from signing #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d excludes all the deployment manifests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's not really any good reason to sign a clickonce deployment manifest and then use --file-list filters to exclude it from being signed. This PR causes such a situation to fail loudly rather than silently signing the rest of the files but not the deployment manifest.
I considered just having the ClickOnceSigner add the deployment manifest file back into
deploymentManifestFilesif it's otherwise empty, but I decided in the end that it's better if the user is required to configure things properly rather than silently fixing it for them.