Skip to content

[release/10.0.1xx] Allow charset to be unset #50963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2025
Merged

[release/10.0.1xx] Allow charset to be unset #50963

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d8f918
Allow charset to be `unset`
rsking Jul 22, 2024
56ccb8e
Merge branch 'release/10.0.1xx' into backport/pr-42266-to-release/10.…
SimonZhao888 Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/BuiltInTools/dotnet-format/Formatters/CharsetFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ private static byte[] GetEncodedBytes(string text, Encoding encoding)
private static bool TryGetCharset(AnalyzerConfigOptions analyzerConfigOptions, [NotNullWhen(true)] out Encoding? encoding)
{
if (analyzerConfigOptions != null &&
analyzerConfigOptions.TryGetValue("charset", out var charsetOption))
analyzerConfigOptions.TryGetValue("charset", out var charsetOption) &&
charsetOption != "unset")
{
encoding = GetCharset(charsetOption);
return true;
Expand Down
Loading