Utilize ShellName and Add Test to Enable Completions W/out Shell on Unix #48918
+26
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I confirmed the proposal by Kalle, dotnet#48420 that the shellMap that gets provided is a default list of shell names like "fish" or "zsh" that are stored in the Shell Env Var. They are all lowercase in the shell map.
There was a problem hiding this comment.
Pull Request Overview
This PR aims to enable static completions to work in scenarios where a shell has not been specified on Unix by leveraging a default mapping of lowercase shell names. Key changes include:
- Adding a test (ShellDiscoveryTests.cs) to validate that the completions command works without an explicit shell.
- Updating CompletionsCommand.cs to convert the shell name to lowercase before lookup in the shell map.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/dotnet.Tests/CompletionTests/ShellDiscoveryTests.cs | Adds a new test ensuring completions work even without a specified shell. |
| src/System.CommandLine.StaticCompletions/CompletionsCommand.cs | Normalizes the shell name to lowercase to match against the shell map. |
baronfel
reviewed
May 13, 2025
|
|
||
| public class ShellDiscoveryTests() | ||
| { | ||
| [Fact] |
There was a problem hiding this comment.
maybe parameterize this test with the shell names and set the SHELL env var before each run so we can easily test all of our shell experiences??
baronfel
approved these changes
May 13, 2025
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirmed the proposal by Kalle, which resolves #48420 and confirmed that the shellMap that gets provided is a default list of shell names like "fish" or "zsh" that are stored in the Shell Env Var. They are all lowercase in the shell map.