Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported _AggressiveAttributeTrimming switch #44968

Closed
wants to merge 1 commit into from
Closed

Remove unsupported _AggressiveAttributeTrimming switch #44968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,11 +524,6 @@ Copyright (c) .NET Foundation. All rights reserved.
Value="$(VerifyDependencyInjectionOpenGenericServiceTrimmability)"
Trim="true" />

<RuntimeHostConfigurationOption Include="System.AggressiveAttributeTrimming"
Condition="'$(_AggressiveAttributeTrimming)' != ''"
Value="$(_AggressiveAttributeTrimming)"
Trim="true" />

Comment on lines -527 to -531
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are things structured in the SDK - if we remove it here, would it also be unavailable when building a .NET 8 app using a .NET 10 SDK?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, great point... I think then we'll need to leave it in the SDK.

<RuntimeHostConfigurationOption Include="System.ComponentModel.DefaultValueAttribute.IsSupported"
Condition="'$(_DefaultValueAttributeSupport)' != ''"
Value="$(_DefaultValueAttributeSupport)"
Expand Down
1 change: 0 additions & 1 deletion test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAProjectWithAllFeatures.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ public void It_publishes_the_project_correctly(string targetFramework, string[]
""runtimeOptions"": {
""configProperties"": {
""Microsoft.Extensions.DependencyInjection.VerifyOpenGenericServiceTrimmability"": true,
""System.AggressiveAttributeTrimming"": true,
""System.ComponentModel.DefaultValueAttribute.IsSupported"": true,
""System.ComponentModel.Design.IDesignerHost.IsSupported"": true,
""System.ComponentModel.TypeConverter.EnableUnsafeBinaryFormatterInDesigntimeLicenseContextSerialization"": false,
Expand Down
1 change: 0 additions & 1 deletion test/TestAssets/TestProjects/KitchenSink/TestApp/TestApp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
Keep this list in the same order as the configProperties in GivenThatWeWantToPublishAProjectWithAllFeatures. -->
<PropertyGroup>
<VerifyDependencyInjectionOpenGenericServiceTrimmability>true</VerifyDependencyInjectionOpenGenericServiceTrimmability>
<_AggressiveAttributeTrimming>true</_AggressiveAttributeTrimming>
<_DefaultValueAttributeSupport>true</_DefaultValueAttributeSupport>
<_DesignerHostSupport>true</_DesignerHostSupport>
<EnableUnsafeBinaryFormatterInDesigntimeLicenseContextSerialization>false</EnableUnsafeBinaryFormatterInDesigntimeLicenseContextSerialization>
Expand Down