Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete outdated constructors on Rfc2898DeriveBytes #67158

Merged
merged 1 commit into from
Mar 26, 2022

Conversation

vcsjones
Copy link
Member

Contributes to #57046

Places where the tests were not explicitly testing the default parameters I updated to use the explicit defaults. Places where the defaults were being tested for... defaultness... got a suppression.

@vcsjones vcsjones requested a review from jeffhandley as a code owner March 25, 2022 19:42
@ghost ghost assigned vcsjones Mar 25, 2022
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Mar 25, 2022

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #57046

Places where the tests were not explicitly testing the default parameters I updated to use the explicit defaults. Places where the defaults were being tested for... defaultness... got a suppression.

Author: vcsjones
Assignees: vcsjones
Labels:

area-System.Security, new-api-needs-documentation

Milestone: -

@vcsjones vcsjones added breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. and removed new-api-needs-documentation labels Mar 25, 2022
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Mar 25, 2022
@ghost
Copy link

ghost commented Mar 25, 2022

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

@bartonjs
Copy link
Member

bartonjs commented Mar 26, 2022

Opened paperwork at dotnet/docs#28812.

@bartonjs bartonjs merged commit e961b10 into dotnet:main Mar 26, 2022
@vcsjones vcsjones deleted the rfc2898ctor branch March 26, 2022 00:38
@ghost ghost locked as resolved and limited conversation to collaborators Apr 25, 2022
@ericstj ericstj added this to the 7.0.0 milestone Sep 15, 2022
@bartonjs bartonjs removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Security breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants