Skip to content

Enable async testing in CI #121857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+16 −4
Open

Enable async testing in CI #121857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d46ffa8
Enable async testing in CI
MichalStrehovsky Nov 20, 2025
96b0577
Disabling
MichalStrehovsky Nov 21, 2025
ae47d74
Also unbreak osx, maybe
MichalStrehovsky Nov 21, 2025
d013470
Add condition to disable project build for arm64
MichalStrehovsky Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eng/pipelines/coreclr/runtime-nativeaot-outerloop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ schedules:

variables:
- template: /eng/pipelines/common/variables.yml
- template: /eng/pipelines/helix-platforms.yml

extends:
template: /eng/pipelines/common/templates/pipeline-with-resources.yml
Expand Down
2 changes: 1 addition & 1 deletion eng/pipelines/runtime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@ extends:
- template: /eng/pipelines/coreclr/nativeaot-post-build-steps.yml
parameters:
creator: dotnet-bot
testBuildArgs: 'nativeaot tree ";nativeaot;Loader;Interop;" /p:BuildNativeAotFrameworkObjects=true'
testBuildArgs: 'nativeaot tree ";nativeaot;Loader;Interop;async;" /p:BuildNativeAotFrameworkObjects=true'
liveLibrariesBuildConfig: Release
testRunNamePrefixSuffix: NativeAOT_$(_BuildConfig)
extraVariablesTemplates:
Expand Down
5 changes: 4 additions & 1 deletion src/coreclr/tools/Common/Compiler/DependencyAnalysis/MethodReadOnlyDataNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,10 @@ public override bool ShouldSkipEmittingObjectNode(NodeFactory factory)
}
#endif

public override ObjectNodeSection GetSection(NodeFactory factory) => ObjectNodeSection.ReadOnlyDataSection;
// TODO: (async) This should stay RO everywhere: https://github.com/dotnet/runtime/issues/121871
public override ObjectNodeSection GetSection(NodeFactory factory)
=> factory.Target.IsWindows ? ObjectNodeSection.ReadOnlyDataSection : ObjectNodeSection.DataSection;

public override bool StaticDependenciesAreComputed => _data != null;

public void AppendMangledName(NameMangler nameMangler, Utf8StringBuilder sb)
Expand Down
12 changes: 10 additions & 2 deletions src/tests/async/Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,20 @@
<Project>
<PropertyGroup>
<!-- disable building for configurations that do not yet support runtime async. -->
<DisableProjectBuild Condition="'$(RuntimeFlavor)' == 'mono' or '$(TestBuildMode)' == 'nativeaot' or '$(TargetArchitecture)' == 'wasm'">true</DisableProjectBuild>
<DisableProjectBuild Condition="'$(RuntimeFlavor)' == 'mono' or '$(TargetArchitecture)' == 'wasm'">true</DisableProjectBuild>
</PropertyGroup>

<PropertyGroup>
<!-- https://github.com/dotnet/runtime/issues/121872 -->
<DisableProjectBuild Condition="'$(TestBuildMode)' == 'nativeaot' and '$(TargetArchitecture)' == 'x86'">true</DisableProjectBuild>

<!-- https://github.com/dotnet/runtime/issues/121878 -->
<DisableProjectBuild Condition="'$(TestBuildMode)' == 'nativeaot' and '$(TargetArchitecture)' == 'arm64' and ('$(TargetOS)' == 'linux' or '$(TargetOS)' == 'android')">true</DisableProjectBuild>
</PropertyGroup>

<PropertyGroup>
<!-- runtime async testing in main repo NYI -->
<DisableProjectBuild>true</DisableProjectBuild>
<DisableProjectBuild Condition="'$(TestBuildMode)' != 'nativeaot'">true</DisableProjectBuild>
</PropertyGroup>

<Import Project="$([MSBuild]::GetPathOfFileAbove(Directory.Build.targets, $(MSBuildThisFileDirectory)..))" />
Expand Down
Loading