Skip to content

Fix typo: SequenceEquals -> SequenceEqual #119937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 22, 2025
Merged

Fix typo: SequenceEquals -> SequenceEqual #119937

merged 4 commits into from
Sep 22, 2025

Conversation

xtqqczze
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 21, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 21, 2025
@jkotas jkotas mentioned this pull request Sep 22, 2025
Closed
@jkotas
Copy link
Member

jkotas commented Sep 22, 2025

/ba-g filled issue #119939

@jkotas
Copy link
Member

jkotas commented Sep 22, 2025

There are many more instances of SequenceEquals, e.g.

runtime/src/libraries/System.Memory/tests/Span/SequenceEqual.T.cs

Line 277 in 171bbb1

public static void SequenceEquals_StructWithExplicitFieldSizeAndNoFields_EqualsAsExpected(int length)
. Are those staying on purpose?

@xtqqczze
Copy link
Contributor Author

There are many more instances of SequenceEquals, e.g.

runtime/src/libraries/System.Memory/tests/Span/SequenceEqual.T.cs

Line 277 in 171bbb1

public static void SequenceEquals_StructWithExplicitFieldSizeAndNoFields_EqualsAsExpected(int length)

. Are those staying on purpose?

Had search set to exclude tests so missed these.

@xtqqczze
Copy link
Contributor Author

cb2bedb also has an additional change to make the naming consistent

@build-analysis build-analysis bot mentioned this pull request Sep 22, 2025
Open
stephentoub
stephentoub approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 1e89955 into dotnet:main Sep 22, 2025
144 checks passed
@xtqqczze xtqqczze deleted the typo-SequenceEquals branch September 22, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees
No one assigned
Labels
community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xtqqczze @jkotas @stephentoub