-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Remove redundant call to SetFree for objects bigger than 4GB #119930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Tagging subscribers to this area: @dotnet/gc |
@dotnet-policy-service agree |
src/coreclr/gc/gc.cpp
Outdated
|
||
#ifdef HOST_64BIT | ||
#ifndef HOST_64BIT | ||
((CObjectHeader*)x)->SetFree(size); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
((CObjectHeader*)x)->SetFree(size); | |
((CObjectHeader*)x)->SetFree(size); |
Indentation is off (applies to the rest of the code as well)
src/coreclr/gc/gc.cpp
Outdated
size_t current_size = UINT32_MAX - get_alignment_constant (FALSE) | ||
- Align (min_obj_size, get_alignment_constant (FALSE)); | ||
|
||
*(((PTR_PTR)tmp)-1) = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really necessary to clear these interim syncblocks? Can we keep "Also clear the syncblock" before #ifndef HOST_64BIT
and delete it here?
Fix #119424