Consider all MemberInfo references for IsCollectible #119869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use ReflectedType instead DeclaringType since ReflectedType can be colletible even when DeclaringType is not. These fixes support typical IsCollectible use case where the property is used to determine whether or how the reflection objects can be cached. Fix dotnet#119697
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the IsCollectible property implementation across various reflection member types to use ReflectedType instead of DeclaringType when determining collectibility. This ensures proper caching behavior in scenarios where the reflected type can be collectible even when the declaring type is not collectible.
Key changes:
- Updated
IsCollectibleproperty implementations inRuntimePropertyInfo,RuntimeFieldInfo,RuntimeEventInfo, andRuntimeConstructorInfoto useReflectedTypeInternal.IsCollectible - Enhanced
RuntimeMethodInfo.IsCollectibleto check both reflected type and method handle collectibility - Refactored test methods from theory-based to fact-based tests that iterate through all members
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| RuntimePropertyInfo.cs | Changed IsCollectible to use ReflectedTypeInternal instead of m_declaringType |
| RuntimeMethodInfo.CoreCLR.cs | Added check for ReflectedTypeInternal.IsCollectible before existing method handle check |
| RuntimeFieldInfo.cs | Changed IsCollectible to use ReflectedTypeInternal instead of m_declaringType |
| RuntimeEventInfo.cs | Changed IsCollectible to use ReflectedTypeInternal instead of m_declaringType |
| RuntimeConstructorInfo.CoreCLR.cs | Changed IsCollectible to use ReflectedTypeInternal instead of m_declaringType |
| IsCollectibleTests.cs | Refactored from theory-based tests to comprehensive fact-based tests iterating through all members |
|
Tagging subscribers to this area: @dotnet/area-system-reflection |
jkotas
added a commit
to jkotas/dotnet-api-docs
that referenced
this pull request
Sep 19, 2025
MemberInfo can reference multiple different assemblies (e.g. via generic instantiation or via reflected type). IsCollectible property must take all references into account. Related to dotnet/runtime#119869
|
Also, I have submitted clarification for the docs repo: dotnet/dotnet-api-docs#11825 |
jkoritzinsky
approved these changes
Sep 19, 2025
jkotas
added a commit
to jkotas/runtime
that referenced
this pull request
Sep 19, 2025
…otnet#119869) Use ReflectedType instead DeclaringType since ReflectedType can be colletible even when DeclaringType is not. These fixes support typical IsCollectible use case where the property is used to determine whether or how the reflection objects can be cached. Fix dotnet#119697
4 tasks
xtqqczze
pushed a commit
to xtqqczze/dotnet-runtime
that referenced
this pull request
Sep 20, 2025
Use ReflectedType instead DeclaringType since ReflectedType can be colletible even when DeclaringType is not. These fixes support typical IsCollectible use case where the property is used to determine whether or how the reflection objects can be cached. Fix dotnet#119697
BillWagner
pushed a commit
to dotnet/dotnet-api-docs
that referenced
this pull request
Sep 22, 2025
MemberInfo can reference multiple different assemblies (e.g. via generic instantiation or via reflected type). IsCollectible property must take all references into account. Related to dotnet/runtime#119869
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ReflectedType instead DeclaringType since ReflectedType can be colletible even when DeclaringType is not.
These fixes support typical IsCollectible use case where the property is used to determine whether or how the reflection objects can be cached.
Fix #119697