Skip to content

Conversation

MichalStrehovsky
Copy link
Member

@Copilot Copilot AI review requested due to automatic review settings July 25, 2025 09:55
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated DEFAULT_STACK_SIZE property bag functionality from the CoreCLR runtime. The change eliminates legacy code that parsed stack size configuration through the host property bag mechanism.

  • Removes the ParseDefaultStackSize function and related static variable
  • Eliminates property bag parsing for DEFAULT_STACK_SIZE in the host creation process
  • Simplifies stack size determination to use only environment variables and configuration values

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/coreclr/vm/threads.cpp Removes ParseDefaultStackSize function, static variable, and simplifies GetDefaultStackSizeSetting logic
src/coreclr/vm/corhost.cpp Removes property bag parsing for DEFAULT_STACK_SIZE during app domain creation

Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@am11
Copy link
Member

am11 commented Jul 25, 2025

LGTM, I thought we had an environment variable called DEFAULT_STACK_SIZE, but this is actually the name used in property bag for hosting layer. (It was anyway irrelevant for public doc since environment var can't influence the value)

@MichalStrehovsky MichalStrehovsky added the blocked Issue/PR is blocked on something - see comments label Jul 25, 2025
@MichalStrehovsky
Copy link
Member Author

This probably won't make .NET 10 anymore. ASP.NET repo is still on a dotnet/runtime that doesn't support the documented replacement so I can't replace the use of this with the new one. The flow is blocked on dotnet/aspnetcore#63109. It's probably fine...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-VM-coreclr blocked Issue/PR is blocked on something - see comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants