Add packaging information to windowsdesktop transport package #115477
+55
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to dotnet/windowsdesktop#4998 Adds a props file that gets auto-imported when referencing the internal windowsdesktop transport package. This file defines an item `PackageLibrary` that includes all the information for the runtime assemblies that get redistributed inside the package. This information can then be used in windowsdesktop to auto-generate parts of the PackageOverrides.txt file.
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR adds packaging information to the WindowsDesktop transport package by introducing a props file with package metadata, updating the project file to generate that props file, and propagating the package properties through the packaging targets.
- Adds a new props file with detailed packaging info.
- Updates the project file to generate the transport props file.
- Adjusts packaging.targets to flow package properties to consumer projects.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/libraries/Microsoft.Internal.Runtime.WindowsDesktop.Transport/src/build/Microsoft.Internal.Runtime.WindowsDesktop.Transport.props | New props file to specify packaging metadata for redistributed assemblies |
| src/libraries/Microsoft.Internal.Runtime.WindowsDesktop.Transport/src/Microsoft.Internal.Runtime.WindowsDesktop.Transport.proj | Introduces a target to generate the props file and adds a package reference |
| eng/packaging.targets | Updates to propagate package properties to consuming projects |
...WindowsDesktop.Transport/src/build/Microsoft.Internal.Runtime.WindowsDesktop.Transport.props
Outdated
Show resolved
Hide resolved
…ort/src/build/Microsoft.Internal.Runtime.WindowsDesktop.Transport.props Co-authored-by: Copilot <[email protected]>
ViktorHofer
added a commit
to dotnet/windowsdesktop
that referenced
this pull request
May 12, 2025
ViktorHofer
added
area-Infrastructure-libraries
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
jkoritzinsky
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/windowsdesktop#4998
Adds a props file that gets auto-imported when referencing the internal windowsdesktop transport package. This file defines an item
PackageLibrarythat includes all the information for the runtime assemblies that get redistributed inside the package.This information can then be used in windowsdesktop to auto-generate parts of the PackageOverrides.txt file.
I chose the following format as it allows to add more metadata later that isn't strongly tied to packaging.
Result
After taking this picture I then later renamed
PackageLibrarytoRuntimeWindowsDesktopPackageLibrary