Update System.Net.ServerSentEvents.Tests.csproj #115470
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unblocks the use of a newer .NET SDK that contains this runtime commit 819bff1 This is necessary as System.Net.ServerSentEvents got moved inbox.
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR updates the System.Net.ServerSentEvents.Tests.csproj file to unblock the .NET SDK update that relocates System.Net.ServerSentEvents.
- Moved the unconditional ProjectReference for System.Net.ServerSentEvents into a conditional ItemGroup targeting .NETFramework
- Updated the csproj to conform with the runtime commit requirements
Comments suppressed due to low confidence (1)
src/libraries/System.Net.ServerSentEvents/tests/System.Net.ServerSentEvents.Tests.csproj:22
- Moving the ProjectReference into a .NETFramework-specific ItemGroup may result in the reference being omitted for non-.NETFramework targets. Please ensure that this conditional reference is intentional based on the supported target frameworks.
<ProjectReference Include="..\src\System.Net.ServerSentEvents.csproj" />
stephentoub
approved these changes
May 12, 2025
This was referenced May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks the use of a newer .NET SDK that contains this runtime commit 819bff1
This is necessary as System.Net.ServerSentEvents got moved inbox.