Don't allow mutating the ScopeId on static readonly IPAddress fields #115456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Address field was made readonly in dotnet/corefx#33531. Somehow ScopeId, the only other mutatable property, was missed. I did not see discussion of this in that PR or the related issue. An example program that illistrates the problem: ```csharp Console.WriteLine(IPAddress.IPv6Loopback); IPAddress.IPv6Loopback.ScopeId = 1; Console.WriteLine(IPAddress.IPv6Loopback); ``` This prints: ```txt ::1 ::1%1 ``` I think the right behavior is to throw when setting the ScopeId (this pr). Contributes to dotnet#27870
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/ncl |
MihaZupan
approved these changes
May 12, 2025
|
test failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
IPAddressclass has somestatic readonlyinstances ofIPAddressdeclared on it. TheAddressfield of these instances was made readonly in dotnet/corefx#33531. SomehowScopeId, the only other mutable property, was missed. I did not see discussion of this in that PR or the related issue.An example program that illustrates the problem:
When run, this program prints the following, showing that the
static readonlyinstance has been mutated:I think the right behavior is to throw when setting the
ScopeId(this pr).Contributes to #27870