[cDAC] Fix issues found when running full SOS test suite #115432
+98
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run dotnet-diagnostics |
|
No pipelines are associated with this pull request. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes several issues encountered during full SOS test suite runs by properly handling flag values and frame names, as well as updating pipeline configurations for enforced debug builds.
- Update of GetAssemblyList parameter to allow null values.
- Correction of loop condition and flag check logic in GetAssemblyList and IXCLRDataModule.GetFlags.
- Expanded enum definitions and pipeline configuration adjustments.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs | Updated nullability for the values array, modified loop condition, and adjusted debug handling in GetAssemblyList and GetFrameName. |
| src/native/managed/cdac/mscordaccore_universal/Legacy/ISOSDacInterface.cs | Updated the interface to accept a nullable values array in GetAssemblyList. |
| src/native/managed/cdac/mscordaccore_universal/Legacy/ClrDataModule.cs | Corrected the flag check from EditAndContinue to ReflectionEmit to accurately reflect module properties. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/FrameIterator.cs | Added several frame type enum members to support additional frame types. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Loader_1.cs | Expanded and updated ModuleFlags_1 enum definitions and updated GetFlags accordingly. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/ILoader.cs | Updated ModuleFlags definition to match changes applied in Loader_1.cs. |
| eng/pipelines/runtime-diagnostics.yml | Adjusted build arguments to force Debug mode and propagate configuration values. |
Comments suppressed due to low confidence (1)
eng/pipelines/runtime-diagnostics.yml:44
- [nitpick] Confirm that enforcing Debug configuration via '-c Debug' is intentional for all builds and does not conflict with other pipeline or project configuration defaults.
buildArgs: -s clr+libs+tools.cdac+host+packs -c Debug -rc $(_BuildConfig) -lc $(_BuildConfig)
|
Tagging subscribers to this area: @tommcdon |
|
/azp run runtime-diagnostics |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced May 9, 2025
mikem8361
approved these changes
May 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipeline Changes
runtime-diagnosticspipeline to build the cDAC in debug mode. This enforces the debug assertions during testing.Fixes
ISOSDacInterface::GetModuleDatabecause it enforced only sending flag values that were defined in the cDAC. Clients expected flag data that was not defined in the module flag enum, this PR adds all flags currently defined in the runtime.ISOSDacInterface::GetFrameNameonly worked on Frame names implemented in the cDAC. This PR adds the rest of the Frames used in any version of the runtime to possible return values.ISOSDacInterface::GetFrameNamereturn valuepNeededreturns a different number depending on if a return buffer is provided. If a return buffer is provided it returns the number of characters in the Frame name. If a return buffer is not provided it returns the number of characters in the Frame name + 1 (for a null terminator). This PR implements this behavior to match the DAC.IXCLRDataModule::GetFlagshad a bug where it switched on the wrong enum value (oops).ISOSDacInterface::GetAssemblyListhad a bug in its debug verification logic. The DAC implementation has a different behavior if thevaluesarray is null or not. This led to incorrectcountvalues being returned.