Skip to content

[mono] Exclude 32bit more #115426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025
Merged

[mono] Exclude 32bit more #115426

merged 2 commits into from
May 9, 2025

Conversation

lewing
Copy link
Member

@lewing lewing commented May 9, 2025

should fix #115404 as well as the runtime-extra-platforms failures

@Copilot Copilot AI review requested due to automatic review settings May 9, 2025 15:48
@lewing lewing requested a review from kotlarmilos May 9, 2025 15:48
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 9, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the intrinsic handling logic in Mono by excluding unsupported 32-bit platforms. Key changes include:

  • Adding a conditional compilation check for 64-bit and WebAssembly targets using "#if TARGET_SIZEOF_VOID_P == 8 || defined(TARGET_WASM)".
  • Introducing an #else branch that returns NULL when the target is not 64-bit or WASM.
  • Ensuring the intrinsic behavior is limited to supported platforms.

@lewing lewing requested a review from akoeplinger May 9, 2025 15:49
@lewing
Copy link
Member Author

lewing commented May 9, 2025

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@kotlarmilos kotlarmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lewing
Copy link
Member Author

lewing commented May 9, 2025

/ba-g merge ahead of long-running test timeouts to reduce ci redness

@lewing lewing merged commit 1db2101 into dotnet:main May 9, 2025
75 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

android-arm Release AllSubsets_Mono crashes in System.Runtime.Tests with missing opcode
2 participants