Don't call fgMorphBlockStmt in LoopClonning #113558
Merged
+17
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
EgorBo
commented
Mar 15, 2025
|
|
||
| // Add jmpTrue "cond == 0" | ||
| GenTree* cond = conds[i].ToGenTree(comp, newBlk, /* invert */ true); | ||
| cond->gtFlags |= (GTF_RELOP_JMP_USED | GTF_DONT_CSE); |
There was a problem hiding this comment.
this is our regular routine for conditions inside JTRUE (fgMorphBlockStmt call used to set these flags for us).
|
Seems like another +1 for separating out the "optimization" parts of morph from its other duties. |
|
PTAL @AndyAyersMS @BruceForstall @dotnet/jit-contrib No diffs, the only ci failure is not related. |
AndyAyersMS
approved these changes
Mar 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't call
fgMorphBlockStmtin loop clonning - morph might alter control flow (e.g. change BBJ_TRUE to BBJ_ALWAYS) and loop cloning doesn't expect that when it wires up blocks. It never happens today (we're lucky), but might be needed for Loop clonning for Spans (e.g. to foldlocalRef != nullcondition). Actually, we might hit it (in theory) for stack-allocated arrays as well 🤔Also, I've removed the unreachable "multiple-conditions per block" code (it's when we merge multiple conditions into a single JTRUE with
GT_AND) - I don't think we'll ever need it as the conditions that it creates are unfriendly for assertion propagation. It is more of a task for the lateifConversionphase.I recommend reviewing the pr with
Expected to be zero-diff.