[release/9.0-staging] Bump System.Text.Json toolset version #113385
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
|
Do any of the tasks that use this ship in the product - and if so - can we guarantee that every VS version that supports 9.0 will have this update to MSBuild? |
@akoeplinger indicated VS 17.4 has the 9 bump. Is that the min VS version for 9? https://github.com/dotnet/msbuild/blob/vs17.14/src/MSBuild/app.config#L107-L110 |
No: 
|
| <PackageReference Include="System.Reflection.Metadata" Version="$(SystemReflectionMetadataToolsetVersion)" ExcludeAssets="Runtime" PrivateAssets="All" /> | ||
| <PackageReference Include="System.Text.Json" Version="$(SystemTextJsonToolsetVersion)" ExcludeAssets="Runtime" PrivateAssets="All" NoWarn="NU1901;NU1902;NU1903;NU1904" /> | ||
| <PackageDownloadAndReference Include="Microsoft.Bcl.AsyncInterfaces" Version="$(MicrosoftBclAsyncInterfacesToolsetVersion)" Folder="lib/net462" /> | ||
| <PackageDownloadAndReference Include="System.Buffers" Version="$(SystemBuffersToolsetVersion)" Folder="lib/net461" /> |
There was a problem hiding this comment.
should we reference ref/net45 instead of the lib assembly? or does it not matter?
There was a problem hiding this comment.
Yes, the nearest ref assembly should be referenced if there's one. In this case there is one.
There was a problem hiding this comment.
The other two packages that have a ref folder are fine as-is as they don't have a ref for .NET Framework:
- System.Threading.Tasks.Extensions
- System.Memory
|
@steveisok Friendly reminder that code complete is on April 14th for the May Release. If you'd like to get this change included in that release, please get a Tactics approval (if product change) and merge this PR before that date. |
Backport of #113384 to release/9.0-staging
/cc @steveisok
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.