[cdac] Remove GetMethodDescData fallback to legacy DAC #110702
Conversation
|
Tagging subscribers to this area: @tommcdon |
|
Do you think it would be beneficial to verify that the HResult is the same for cDAC/DAC in debug builds? Previously this didn't matter as if the cDAC returned Instead of immediately returning on failure, we could call the fallback and assert the same result code, then return the cDAC result. |
|
I think that makes sense for the error cases that aren't just basic input checks. I'll switch the various debug-only checks we have against for cDAC/DAC match to compare the HRESULTs if cDAC throws/catches an exception. |
| @@ -264,7 +264,7 @@ public TypeHandle GetTypeHandle(TargetPointer typeHandlePointer) | |||
|
|
|||
| if ((addressLowBits != TypeHandleBits.MethodTable) && (addressLowBits != TypeHandleBits.TypeDesc)) | |||
| { | |||
| throw new InvalidOperationException("Invalid type handle pointer"); | |||
| throw new ArgumentException("Invalid type handle pointer", nameof(typeHandlePointer)); | |||
There was a problem hiding this comment.
Switched these to match the HRESULT returned by the DAC. Found via @max-charlamb's suggestion in #110702 (comment)
After #110322 goes in, the cDAC
GetMethodDescDataimplementation should be done, so we can stop delegating to the legacy DAC as a fallback.Contributes to #109426.