Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cdac] Always re-read global pointers in GetUsefulGlobals #110633

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Dec 12, 2024

GetUsefulGlobals can be called before the runtime is actually initialized, so we need to re-read the global pointers instead of storing any of them.

Contributes to #99302

Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@tommcdon tommcdon added the enhancement Product code improvement that does NOT require public API changes/additions label Dec 12, 2024
@elinor-fung elinor-fung merged commit f0e64f5 into dotnet:main Dec 12, 2024
147 checks passed
@elinor-fung elinor-fung deleted the cdac-fixGetUsefulGlobals branch December 12, 2024 21:58
hez2010 pushed a commit to hez2010/runtime that referenced this pull request Dec 14, 2024
)

`GetUsefulGlobals` can be called before the runtime is actually initialized, so we need to re-read the global pointers instead of storing any of them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Diagnostics-coreclr enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants