Avoid package dependencies on libraries in the shared framework #106172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can avoid these dependencies since we can count on the library being part of the shared framework. Fewer dependencies means less packages downloaded, less for customers to service, less copied into the output directory when serviced.
ViktorHofer
reviewed
Aug 9, 2024
ViktorHofer
reviewed
Aug 9, 2024
ViktorHofer
reviewed
Aug 9, 2024
ViktorHofer
reviewed
Aug 9, 2024
carlossanlop
reviewed
Aug 9, 2024
carlossanlop
reviewed
Aug 9, 2024
carlossanlop
reviewed
Aug 9, 2024
3 tasks
carlossanlop
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Feedback addressed. Do you feel like the open conversations have been addressed too, or do you want to wait for @ViktorHofer 's final input there?
I think we closed on those discussions. I resolved them. |
This was referenced Aug 28, 2024
ericstj
added a commit
to ericstj/runtime
that referenced
this pull request
Aug 29, 2024
…et#106172) * Avoid package dependencies on libraries in the shared framework We can avoid these dependencies since we can count on the library being part of the shared framework. Fewer dependencies means less packages downloaded, less for customers to service, less copied into the output directory when serviced. * Add warning code. * Address feedback
ericstj
added a commit
to ericstj/runtime
that referenced
this pull request
Aug 29, 2024
…et#106172) * Avoid package dependencies on libraries in the shared framework We can avoid these dependencies since we can count on the library being part of the shared framework. Fewer dependencies means less packages downloaded, less for customers to service, less copied into the output directory when serviced. * Add warning code. * Address feedback
4 tasks
ericstj
added a commit
that referenced
this pull request
Sep 5, 2024
#107161) * Avoid package dependencies on libraries in the shared framework (#106172) * Avoid package dependencies on libraries in the shared framework We can avoid these dependencies since we can count on the library being part of the shared framework. Fewer dependencies means less packages downloaded, less for customers to service, less copied into the output directory when serviced. * Add warning code. * Address feedback * Add an option to enable servicing for transitive dependencies * Enable all packages that removed dependencies * Add additional packages required for up-stack servicing * Permit settting ServiceTransitiveDependencies in projects as well
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105120
We can avoid these dependencies since we can count on the library being part of the shared framework. Fewer dependencies means less packages downloaded, less for customers to service, less copied into the output directory when serviced.
NuSpec differences: ericstj/diffs@ee014f1