Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cdac] Begin adding MethodDesc APIs to the RuntimeTypeSystem contract #104811

Merged
merged 25 commits into from
Jul 20, 2024
+522 −19
Merged

[cdac] Begin adding MethodDesc APIs to the RuntimeTypeSystem contract #104811

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
ffc4b8a
start GetMethodDescDataImpl
lambdageek Jul 8, 2024
9e0272a
WIP: managed GetMethodDescData skeleton
lambdageek Jul 8, 2024
29e404c
wip: MethodDesc
lambdageek Jul 9, 2024
9719c75
add MethodDescChunk
lambdageek Jul 10, 2024
f076f19
WIP: validating a MethodDesc
lambdageek Jul 11, 2024
c935626
checkpoint: MethodDesc validation
lambdageek Jul 12, 2024
fa42ef0
update contract
lambdageek Jul 12, 2024
27f4a96
fix RuntimeTypeSystem unit tests
lambdageek Jul 12, 2024
9dbd432
update contract
lambdageek Jul 15, 2024
793681f
fix GetMethodDescChunkPointerMayThrow
lambdageek Jul 15, 2024
a46f91e
fixup rebase
lambdageek Jul 16, 2024
3f82a89
add data descriptor description to the contract
lambdageek Jul 18, 2024
8111d53
Apply suggestions from code review
lambdageek Jul 19, 2024
07c810e
MayThrow -> Throwing
lambdageek Jul 19, 2024
6f1d9a8
Slot is ushort not byte
lambdageek Jul 19, 2024
fa42684
remove unused property
lambdageek Jul 19, 2024
9613999
add TargetPointer 32-/64-bit max constants
lambdageek Jul 19, 2024
214ffe9
use NewArrayHolder
lambdageek Jul 19, 2024
c6e057a
spelling
lambdageek Jul 19, 2024
b000f7a
add globals to RTS contract
lambdageek Jul 19, 2024
dc1812c
Merge remote-tracking branch 'origin/main' into cdac-methoddesc
lambdageek Jul 19, 2024
d4f6299
remove unused usings
lambdageek Jul 19, 2024
10f0943
constexpr cdac_offsets, not const
lambdageek Jul 19, 2024
515a3e3
Apply suggestions from code review
lambdageek Jul 20, 2024
1f182f1
make GetNumVtableSlots private
lambdageek Jul 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update contract
@lambdageek
lambdageek committed Jul 18, 2024
commit 9dbd432bd6af08850ff67796283e5f3860622ea9
2 changes: 1 addition & 1 deletion src/coreclr/debug/runtimeinfo/datadescriptor.h
View file
Original file line number Diff line number Diff line change
@@ -191,7 +191,7 @@ CDAC_TYPE_FIELD(Module, /*pointer*/, TypeDefToMethodTableMap, cdac_offsets<Modul
CDAC_TYPE_FIELD(Module, /*pointer*/, TypeRefToMethodTableMap, cdac_offsets<Module>::TypeRefToMethodTableMap)
CDAC_TYPE_END(Module)

// Metadata
// RuntimeTypeSystem

CDAC_TYPE_BEGIN(MethodTable)
CDAC_TYPE_INDETERMINATE(MethodTable)