-
Notifications
You must be signed in to change notification settings - Fork 5k
Add DivRem with DivisionRounding (WIP + Review request) #104589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DivRem with DivisionRounding (WIP + Review request) #104589
Conversation
Note regarding the
|
Note regarding the
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
src/libraries/apicompat/ApiCompatBaseline.NetCoreAppLatestStable.xml
Outdated
Show resolved
Hide resolved
@tannergooding Would you be able to comment on the |
@heathbm I was finally able to take a look at this. I think it's on the right track. I merged main into your branch and fixed one error in the suppression file. Are you still up for implementing the rest of it? Thanks for your patience and your efforts on this. |
This pull request has been automatically marked |
This pull request will now be closed since it had been marked |
Partial implementation of #93568 (requesting review of general approach before implementing other types since this is mostly copy & paste).
Done:
System
IBinaryInteger
DivRem
implementationDivRem
implementation forInt32
DivisionRounding
forInt32.DivRem
Todo:
DivRem
implementations for remaining typesDivide
andRemainder
methods for all typesThanks for the feedback!