Fix DI scoping violation in RazorSourceGeneratorTestsBase

[Copilot]

The test infrastructure assigns the root service provider to HttpContext.RequestServices, causing InvalidOperationException when resolving scoped services like IViewBufferScope in environments with strict DI validation (.NET 8+). This fails 66/166 tests on Ubuntu 24.04 with .NET 8.0.21.

Changes

• Create service scope with app.Services.CreateScope() and assign to RequestServices
• Use scoped provider for ActivatorUtilities.CreateInstance<RazorView>()
• Properly dispose scope with using statement

// Before
var httpContext = new DefaultHttpContext
{
    RequestServices = app.Services  // ❌ Root provider
};

// After
using var scope = app.Services.CreateScope();
var httpContext = new DefaultHttpContext
{
    RequestServices = scope.ServiceProvider  // ✅ Scoped provider
};

Aligns with ASP.NET Core DI lifetime semantics.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>DI Scoping Bug in RazorSourceGeneratorTestsBase Causes Test Failures</issue_title>
<issue_description># DI Scoping Bug in RazorSourceGeneratorTestsBase Causes Test Failures

Summary

The Microsoft.NET.Sdk.Razor.SourceGenerators.Test test suite fails with 66 out of 166 tests (40%) throwing InvalidOperationException: Cannot resolve scoped service 'Microsoft.AspNetCore.Mvc.ViewFeatures.Buffers.IViewBufferScope' from root provider due to improper dependency injection scoping in the test infrastructure.

Environment

• OS: Ubuntu 24.04.3 LTS (WSL2)
• .NET SDK: 9.0.111
• .NET Runtime: 8.0.21, 9.0.10
• Commit: 1f0c390 (PR Don't put breakpoints on component start tags, end tags or attributes #12422)

Steps to Reproduce

1. Clone the repository
2. Run ./restore.sh
3. Run ./build.sh -test
4. Observe test failures in Microsoft.NET.Sdk.Razor.SourceGenerators.Test

Expected Behavior

All 166 tests should pass.

Actual Behavior

66 tests fail with:

System.InvalidOperationException : Cannot resolve scoped service 'Microsoft.AspNetCore.Mvc.ViewFeatures.Buffers.IViewBufferScope' from root provider.

Example Stack Trace

at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteValidator.ValidateResolution(ServiceCallSite callSite, IServiceScope scope, IServiceScope rootScope)
at Microsoft.Extensions.DependencyInjection.ServiceProvider.OnResolve(ServiceCallSite callSite, IServiceScope scope)
at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(ServiceIdentifier serviceIdentifier, ServiceProviderEngineScope serviceProviderEngineScope)
at Microsoft.AspNetCore.Mvc.Razor.RazorView.RenderAsync(ViewContext context)
at Microsoft.NET.Sdk.Razor.SourceGenerators.RazorSourceGeneratorTestsBase.RenderRazorPageAsync(Compilation compilation, String name)

Test Results

Before fix:

Microsoft.NET.Sdk.Razor.SourceGenerators.Test  Total: 166, Errors: 0, Failed: 66, Skipped: 0, Time: 576.302s

After fix:

Microsoft.NET.Sdk.Razor.SourceGenerators.Test succeeded (7.1s)

Root Cause

In src/Compiler/test/Microsoft.NET.Sdk.Razor.SourceGenerators.Tests/RazorSourceGeneratorTestsBase.cs at line 155, the test code assigns the root service provider to HttpContext.RequestServices:

var app = appBuilder.Build();
var httpContext = new DefaultHttpContext
{
    RequestServices = app.Services  // ❌ Root provider
};

When RazorView.RenderAsync() executes (line 190), it attempts to resolve IViewBufferScope, which is registered as a scoped service in ASP.NET Core MVC. ASP.NET Core's dependency injection validation (enabled in .NET 8+) correctly prevents resolving scoped services from the root provider.

Solution

Create a service scope before assigning to RequestServices:

var app = appBuilder.Build();
var httpContext = new DefaultHttpContext
{
    RequestServices = app.Services.CreateScope().ServiceProvider  // ✅ Scoped provider
};

Fix

File: src/Compiler/test/Microsoft.NET.Sdk.Razor.SourceGenerators.Tests/RazorSourceGeneratorTestsBase.cs
Line: 155

Before:

RequestServices = app.Services

After:

RequestServices = app.Services.CreateScope().ServiceProvider

This one-line change fixes all 66 failing tests by properly adhering to ASP.NET Core's DI scoping rules.

Additional Context

• This issue may not reproduce in CI if the CBL-Mariner 2.0 container uses an older .NET runtime with less strict DI validation
• The issue manifests on Ubuntu 24.04 with .NET 8.0.21 runtime
• The fix aligns with ASP.NET Core best practices and Microsoft's own DI documentation
• No other code changes are required

Impact

• Current: 66 tests fail on non-container Linux environments
• After Fix: All 166 tests pass
• Risk: Low - the change properly scopes the service provider as intended by ASP.NET Core's design

References

• Microsoft Docs: Dependency injection in ASP.NET Core - Service lifetimes
• Related: ASP.NET Core validation for scoped services
  </issue_description>

Comments on the Issue (you are @copilot in this section)

@davidwengier This one I've never seen fail in any local run or CI, that I can recall. Curious to know more about the process for creating these issues @StevenTCramer if you can share? @davidwengier Interesting. I wonder why this one doesn't fail for us? There are certainly differences between WSL and a "real" Ubuntu machine we do CI on, but I wouldn't have thought any of them would have had any effect on this.

• Fixes DI Scoping Bug in RazorSourceGeneratorTestsBase Causes Test Failures #12429

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[davidwengier]

I've not seen this fail, but I'm happy to believe it did

[ToddGrun]