December 8th, Candidate

[PureWeen]

No description provided.

[Copilot]

Pull request overview

This is a December 8th candidate release PR that includes bug fixes, test coverage improvements, and feature enhancements across multiple areas of the .NET MAUI framework. The changes primarily focus on iOS platform improvements, visual state management, collection view enhancements, and various UI control fixes.

Key changes:

• Fixed iOS-specific issues including SwipeGesture direction updates, NavigationPage TitleView orientation handling, and Slider.UpdateOnTap functionality
• Improved VisualStateManager specificity handling for inherited styles (issue #27202)
• Enhanced Picker item selection preservation during collection modifications
• Added comprehensive test coverage for multiple issues and feature matrices
• Fixed CollectionView visual state management for Background/BackgroundColor properties

Reviewed changes

Copilot reviewed 106 out of 330 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/Controls/src/Core/VisualStateManager.cs	Added debug output and preserved VSM specificity during cloning for inherited styles
src/Controls/src/Core/SetterSpecificity.cs	Modified style specificity calculation to preserve VSM behavior for BasedOn styles
src/Controls/src/Core/Picker/Picker.cs	Fixed SelectedItem preservation when collection items are inserted/removed
src/Controls/src/Core/Platform/GestureManager/GesturePlatformManager.iOS.cs	Added runtime SwipeGesture direction update support for iOS
src/Controls/src/Core/Compatibility/Handlers/NavigationPage/iOS/NavigationRenderer.cs	Fixed TitleView frame updates during orientation changes on iOS 26+
src/Controls/src/Core/Slider/Slider.iOS.cs	Added iOS-specific Slider.UpdateOnTap mapping
src/Controls/src/Core/Handlers/Items2/iOS/CarouselViewController2.cs	Fixed CarouselView position preservation during device rotation
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/*.cs	Added 20+ new test cases for various bug fixes
src/Controls/tests/TestCases.HostApp/Issues/*.cs	Added corresponding host app test implementations
src/Controls/tests/Core.UnitTests/PickerTests.cs	Enhanced Picker tests for collection change scenarios
src/Controls/tests/Core.UnitTests/SwipeViewTests.cs	Added test for SwipeItems logical tree preservation
src/Controls/src/Core/Handlers/Items/iOS/TemplatedCell.cs	Fixed VSM selection color detection to include Background property
src/Controls/src/Core/Handlers/Items/Android/MauiRecyclerView.cs	Fixed header/footer update handling when empty view is displayed
src/Controls/src/Core/TemplateUtilities.cs	Preserved SwipeItems in logical tree during content changes
src/Controls/src/Core/Shapes/Shape.cs	Fixed RoundRectangle measurement to use inner path
src/Controls/src/Core/GradientStop.cs	Simplified GetHashCode to use base implementation
src/Controls/src/Core/SolidColorBrush.cs	Simplified GetHashCode to use base implementation
src/Controls/src/Core/ImageBrush.cs	Simplified GetHashCode to use base implementation
Directory.Build.props	Added TypeScript compilation configuration
Directory.Build.targets	Added TypeScript build target exclusions

Comments suppressed due to low confidence (1)

src/Controls/tests/Core.UnitTests/PickerTests.cs:1

• Duplicate condition: TEST_FAILS_ON_ANDROID is checked twice in the conditional compilation directive. This appears to be a copy-paste error.

using System;

[Copilot]

Debug output statements should be removed before merging to production. These appear to be temporary debugging code for issue #27202 that should not remain in the final release.

Suggested change

	// Debug output for issue #27202
	System.Diagnostics.Debug.WriteLine($"[VSM] GoToState({name}) - VSG specificity: {vsgSpecificity.StyleInfo}");
	System.Diagnostics.Debug.WriteLine($"[VSM] VSM setter specificity will be used");

[Copilot]

Inconsistent indentation: this line uses spaces instead of tabs, while the file appears to use tabs elsewhere. Should use consistent indentation throughout.

Suggested change

	pathBounds = this.GetPath().GetBoundsByFlattening(1);
	pathBounds = this.GetPath().GetBoundsByFlattening(1);

[Copilot]

These navigation steps are added to the existing test but appear to be missing from the original test setup. This suggests the test may have been incomplete or the navigation flow changed. Verify that this doesn't break existing test execution.

[Copilot]

The comment states 'Content and all four SwipeItems' which would be 5 children, but the assertion checks for 5. However, the test setup only adds RightItems and LeftItems (2 SwipeItems), not all four directions. This assertion value appears to be incorrect based on the test setup.

Suggested change

	// Verify SwipeView maintains Content and all four SwipeItems as logical children
	Assert.Equal(5, logicalChildrenCount);
	// Verify SwipeView maintains Content and LeftItems as logical children
	Assert.Equal(2, logicalChildrenCount);

[Copilot]

The XML documentation comment is malformed - it's missing proper line breaks and the sentence structure is unclear. Should be formatted as proper documentation with clear sentence boundaries.

Suggested change

	/// iOS 26+ requires autoresizing masks (UIViewAutoresizing.FlexibleWidth) During orientation changes, the autoresizing mask
	/// automatically adjusts the width, but we need to explicitly update the frame to ensure the
	/// title view uses the full available width from the navigation bar. Without this update,
	/// the title view may not properly expand to fill the navigation bar after rotation.
	/// <summary>
	/// On iOS 26 and later, autoresizing masks (UIViewAutoresizing.FlexibleWidth) are required.
	/// During orientation changes, the autoresizing mask automatically adjusts the width.
	/// However, we need to explicitly update the frame to ensure the title view uses the full available width from the navigation bar.
	/// Without this update, the title view may not properly expand to fill the navigation bar after rotation.
	/// </summary>

[Copilot]

When using cached size, the Measure call passes _measuredSize.Height which was just retrieved from cache, but the comment suggests this is needed for internal state updates. Consider documenting why the full Measure with cached height is necessary instead of just updating state, as this may perform redundant layout calculations.

Suggested change

	// to update the virtual view's internal state and bookkeeping
	// to update the virtual view's internal state and bookkeeping.
	//
	// This call ensures that any internal flags, layout state, or side effects
	// required by the virtual view are properly updated, even if the measured size
	// is already known. Some views may rely on Measure being called to update
	// their internal layout state, trigger events, or prepare for Arrange.
	//
	// Do not remove this call or replace it with a direct state update, as it may
	// cause subtle bugs in layout or rendering. If you need to optimize further,
	// ensure that all required internal state updates are preserved.