Revert CollectionView, the footer moves to the bottom of the page when the empty view or empty view template is enabled #27288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 8 out of 12 changed files in this pull request and generated no comments.
Files not reviewed (4)
- src/Controls/tests/TestCases.HostApp/Issues/Issue24966.xaml: Language not supported
- src/Controls/tests/TestCases.HostApp/Issues/Issue27229.xaml: Language not supported
- src/Controls/tests/TestCases.HostApp/Issues/Issue24966.xaml.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue24966.cs: Evaluated as low risk
This was referenced Jan 22, 2025
jsuarezruiz
requested changes
Jan 23, 2025
rmarinho
reviewed
Jan 23, 2025
yea, we have a tracking issue here I deleted the image and commented out the WinUI Test |
rmarinho
approved these changes
Jan 23, 2025
|
/backport to release/9.0.1xx-sr3 |
|
Started backporting to release/9.0.1xx-sr3: https://github.com/dotnet/maui/actions/runs/12938420967 |
jsuarezruiz
approved these changes
Jan 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Changes made in #24997 modified the EmptyView so that it doesn't always take up the entire height and instead sizes to the content. Though this is a valid scenario, the changes shifted the behavior too far the other direction. We need to look at some options around the use of
LayoutOptionsto influence the sizing here to allow users more flexibility.Issues Fixed
Fixes #27229
Fixes #26838