Skip to content

Conversation

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Dec 11, 2025

Description

This PR enables CoreCLR tests on x64 devices.

Fixes #24316.

Continued from #24325.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables CoreCLR tests on x64 devices by removing a temporary workaround that was conditionally disabling these tests on x64 platforms. The change removes logic that was checking for ARM64 support and Mac platform to determine if CoreCLR tests should run, which was implemented as a workaround for a known runtime issue (dotnet/runtime#121631) that has now been resolved.

Key Changes

  • Removed the coreclr_works and ignore_coreclr variables that were conditionally disabling CoreCLR tests on x64 platforms
  • Updated test variation configurations to use the standard ignore variable instead of the conditional ignore_coreclr

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #6376bd1] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 6376bd16c3dd8acdabef68abc4ac867aefa5bf65 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #6376bd1] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 6376bd16c3dd8acdabef68abc4ac867aefa5bf65 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 6376bd16c3dd8acdabef68abc4ac867aefa5bf65 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #6376bd1] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 6376bd16c3dd8acdabef68abc4ac867aefa5bf65 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #6376bd1] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 6376bd16c3dd8acdabef68abc4ac867aefa5bf65 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #6376bd1] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 6376bd16c3dd8acdabef68abc4ac867aefa5bf65 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #6376bd1] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 6376bd16c3dd8acdabef68abc4ac867aefa5bf65 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #6376bd1] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 6376bd16c3dd8acdabef68abc4ac867aefa5bf65 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #6376bd1] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 6376bd16c3dd8acdabef68abc4ac867aefa5bf65 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #6376bd1] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 139 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ framework: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 9 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 13 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 17 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 13 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 6376bd16c3dd8acdabef68abc4ac867aefa5bf65 [PR build]

@rolfbjarne rolfbjarne merged commit 6a1b94d into net11.0 Dec 12, 2025
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants