Fix bug in PACKAGE.md examples #7561
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a null reference exception (NRE) bug in the PACKAGE.md code examples. The examples were attempting to call .Substring() on a potentially null processedText variable. The fix updates the code to use the original source string for substring operations and renames the variable to normalizedText to better reflect its purpose.
Key Changes:
- Fixed NRE by using
sourceinstead ofnormalizedTextin.Substring()calls - Renamed
processedTexttonormalizedTextfor better clarity and API consistency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tarekgh
reviewed
Nov 29, 2025
| var trimIndex = tokenizer.GetIndexByTokenCountFromEnd(source, 5, out string processedText, out _); | ||
| Console.WriteLine($"5 tokens from end: {processedText.Substring(trimIndex)}"); | ||
| var trimIndex = tokenizer.GetIndexByTokenCountFromEnd(source, 5, out string normalizedText, out _); | ||
| Console.WriteLine($"5 tokens from end: {source.Substring(trimIndex)}"); |
Member
There was a problem hiding this comment.
Need to write it as:
Console.WriteLine($"5 tokens from end: {(normalizedText ?? source).Substring(trimIndex)}");
please fix the other on in line 38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use the code from the README.md to prepare for a demo I am doing tomorrow and I got NRE. We should be using
sourcerather thanprocessedTextand I think it's better to renameprocessedTexttonormalizedTextto express what it is.cc @luisquintanilla @tarekgh