Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect IntPtr null check in FftUtils #7434

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

GrabYourPitchforks
Copy link
Member

Caught by prototype CodeQL rule.

We should not compare an IntPtr value to null since it will always result as not equal. We should compare to IntPtr.Zero instead.

@Copilot Copilot bot review requested due to automatic review settings April 3, 2025 23:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.99%. Comparing base (87e1fec) to head (5c910dd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7434      +/-   ##
==========================================
+ Coverage   68.98%   68.99%   +0.01%     
==========================================
  Files        1482     1482              
  Lines      273876   273876              
  Branches    28250    28254       +4     
==========================================
+ Hits       188944   188974      +30     
+ Misses      77550    77516      -34     
- Partials     7382     7386       +4     
Flag Coverage Δ
Debug 68.99% <100.00%> (+0.01%) ⬆️
production 63.28% <100.00%> (+0.01%) ⬆️
test 89.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Microsoft.ML.TimeSeries/FftUtils.cs 95.20% <100.00%> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@michaelgsharp michaelgsharp merged commit 894f2aa into dotnet:main Apr 7, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants