Use Arcade 8.0, use .NET 8.0, remove old features #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgrawehr
force-pushed
the
MoveToArcadeTo8
branch
2 times, most recently
from
bcb2946 to
dc8ce53
Compare
joperezr
reviewed
Oct 10, 2024
| <PackageReference Include="Moq" Version="4.16.1" /> | ||
| <PackageReference Include="xunit" Version="2.6.3" /> | ||
| <PackageReference Include="xunit.runner.visualstudio" Version="2.5.5"> | ||
| <PackageReference Include="Moq" Version="4.20.70" /> |
There was a problem hiding this comment.
Why are we updating these dependencies? We should be particularly careful with this one.
There was a problem hiding this comment.
These are development dependencies only, so I see no reason why we shouldn't keep up to date. The issue with Moq has been resolved.
krwq
reviewed
Nov 14, 2024
| @@ -405,11 +405,11 @@ private static GpioDriver GetBestDriverForBoardOnWindows() | |||
|
|
|||
| if (baseBoardProduct == HummingBoardProduct || baseBoardProduct.StartsWith($"{HummingBoardProduct} ")) | |||
| { | |||
| return new HummingBoardDriver(); | |||
| throw new PlatformNotSupportedException(); | |||
There was a problem hiding this comment.
consider removing entire if statement
Fix compiler errors and new warnings
There's no need to create another VM inside a VM for the build, also the existing centos images don't seem to support .NET 8.0. Suppress warnings that we no longer support .NET 6.0
That will be a lot of work
No guarantee anything will execute properly yet.
Something is "only" not implemented now
…Of to fail on char. Reason was that "ref T" fields where declared as of Object type, while they should be AddressOfVariable instead.
Don't suppress the last bits, or short and byte will not behave as expected
Now "only" causing a StackOverflow in the compiler
Not sure what happened now, but quite a set of extra tests where required to get back to the previous state.
Let's see what else is still/again broken
Didn't really help the performance just yet
Causing the AwaitTask test to run forever. Not fixed yet, but throws now.
Not sure when all those methods that now only have dummy implementations are actually required. And a test on real hardware is still open.
Async methods don't work reliably yet.
For some reason, that seems to make a difference
pgrawehr
force-pushed
the
MoveToArcadeTo8
branch
from
a46f801 to
9c78a6e
Compare
... when T is an array type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2353 and #2354
Microsoft Reviewers: Open in CodeFlow