Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization and deserialization of the typechecking data #18162

Merged

Conversation

psfinaki
Copy link
Member

@psfinaki psfinaki commented Dec 18, 2024

Part of the Stage 2 as per the design doc.

Copy link
Contributor

❗ Release notes required

@psfinaki,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md No release notes found or release notes format is not correct

@psfinaki psfinaki changed the base branch from main to feature/reuse-typechecking-results December 19, 2024 16:37
@psfinaki psfinaki force-pushed the reuse-typecheck-d branch 2 times, most recently from 8ad0442 to 4cc453e Compare January 6, 2025 15:55
@psfinaki psfinaki changed the title [WIP] Serialization and deserialization of the typechecking data Serialization and deserialization of the typechecking data Feb 6, 2025
@psfinaki psfinaki force-pushed the reuse-typecheck-d branch 2 times, most recently from ec6571b to 2fa7876 Compare February 10, 2025 15:03
@psfinaki psfinaki force-pushed the feature/reuse-typechecking-results branch from 0cdff34 to 3580dd3 Compare February 10, 2025 15:09
@psfinaki psfinaki closed this Feb 10, 2025
@psfinaki psfinaki deleted the reuse-typecheck-d branch February 10, 2025 15:16
@psfinaki psfinaki restored the reuse-typecheck-d branch February 11, 2025 14:26
@psfinaki psfinaki reopened this Feb 11, 2025
@psfinaki
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki psfinaki marked this pull request as ready for review February 14, 2025 16:28
@psfinaki psfinaki requested a review from a team as a code owner February 14, 2025 16:28
@psfinaki
Copy link
Member Author

psfinaki commented Feb 14, 2025

I'll be merging this. There are some very random test failures, don't really understand the pattern there, but cannot repro locally either... will look separately.

Otherwise, CheckedImplFile pickling/unpickling seems to more or less work, TcState is coming up!

@psfinaki psfinaki merged commit 043d448 into dotnet:feature/reuse-typechecking-results Feb 14, 2025
25 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants