Uncomment tests using optional parameters in LINQ #36057
Merged
+1,552
−1,713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
force-pushed
the
ReenableOptionalParameterTests
branch
from
d2ff125 to
da5944b
Compare
roji
force-pushed
the
ReenableOptionalParameterTests
branch
from
da5944b to
dc04bc0
Compare
Newer dotnet SDKs contain the fix for dotnet/csharplang#9246. This reverts commit 4f8ea72. Fixes dotnet#35547
roji
force-pushed
the
ReenableOptionalParameterTests
branch
from
dc04bc0 to
ba813ca
Compare
|
@AndriySvyryd @cincuranet @sampatel looks like we're finally done reacting to changes around first-class spans etc. |
| @@ -969,28 +969,32 @@ protected override Expression VisitMethodCall(MethodCallExpression methodCall) | |||
|
|
|||
| // .NET 10 made changes to overload resolution to prefer Span-based overloads when those exist ("first-class spans"). | |||
| // Unfortunately, the LINQ interpreter does not support ref structs, so we rewrite e.g. MemoryExtensions.Contains to | |||
| // Enumerable.Contains here. See https://github.com/dotnet/runtime/issues/109757. | |||
| // Enumerable.Contains here. See https://github.com/dotnet/runtime/issues/109757,. | |||
AndriySvyryd
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to dotnet SDK 10.0.100-preview.5.25258.31, which contains the fix for dotnet/csharplang#9246.This reverts commit 4f8ea72.
Fixes #35547