-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System.ComponentModel #10965
Merged
Merged
System.ComponentModel #10965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
System.ComponentModel modernizations
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…l.cs so that Designer can work BTW I also edited Issue dotnet#10961 to include this Designer failure
…l.cs so that Designer can work BTW I also edited Issue dotnet#10961 to include this Designer failure
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
gewarren
reviewed
Apr 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all these improvements @DickBaker! I will respond to my comments so you don't have to.
snippets/csharp/System.ComponentModel/TypeConverter/Overview/source.cs
Outdated
Show resolved
Hide resolved
snippets/csharp/System.ComponentModel/RefreshEventHandler/Overview/refreshevent.cs
Outdated
Show resolved
Hide resolved
snippets/csharp/System.ComponentModel/RecommendedAsConfigurableAttribute/Overview/source.cs
Outdated
Show resolved
Hide resolved
snippets/csharp/System.ComponentModel/RecommendedAsConfigurableAttribute/.ctor/source.cs
Outdated
Show resolved
Hide resolved
snippets/csharp/System.ComponentModel/PropertyDescriptorCollection/Overview/source.cs
Outdated
Show resolved
Hide resolved
snippets/csharp/System.ComponentModel/EventDescriptor/Overview/eventdescriptor.cs
Outdated
Show resolved
Hide resolved
snippets/csharp/System.ComponentModel/EventDescriptorCollection/InternalSort/source.cs
Outdated
Show resolved
Hide resolved
snippets/csharp/System.ComponentModel/EventDescriptorCollection/Sort/source.cs
Outdated
Show resolved
Hide resolved
snippets/csharp/System.ComponentModel/PropertyDescriptor/Overview/propertydescriptor.cs
Outdated
Show resolved
Hide resolved
gewarren
approved these changes
Apr 3, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggested changes to 84 projects per Issue #10961