Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into live #20285

Merged
merged 7 commits into from
Aug 26, 2020
Merged

Merge master into live #20285

merged 7 commits into from
Aug 26, 2020

Conversation

cxwtool
Copy link
Contributor

@cxwtool cxwtool commented Aug 26, 2020

Please don't squash-merge this PR.

nxtn and others added 7 commits August 25, 2020 07:44
* Update warn-compiler-option.md

* Update warn-compiler-option.md
Co-authored-by: Joohyung Park <[email protected]>
Co-authored-by: Youssef Victor <[email protected]>
Co-authored-by: Scott Addie <[email protected]>
* Document ProtoBuf repeated/map use read-only props

Document that the Protocol Buffer generated C# code for repeated and map
fields use read-only properties that have mutable instances. Include
links to the reference documentation for `RepeatedField<T>` and
`MapField<K, V>`.

These improvements are based on
grpc/grpc-dotnet#1012

* Move link references above the footer
* Update FSI docs to cover `dotnet fsi` and package management

* Update index.md

* Update docs/fsharp/tutorials/fsharp-interactive/index.md

Co-authored-by: Phillip Carter <[email protected]>

* Update docs/fsharp/tutorials/fsharp-interactive/index.md

Co-authored-by: Phillip Carter <[email protected]>

* Update docs/fsharp/tutorials/fsharp-interactive/index.md

Co-authored-by: Phillip Carter <[email protected]>

Co-authored-by: Phillip Carter <[email protected]>
@Youssef1313
Copy link
Member

GitHub shows: OpenPublishing.Build — Validation status: passed, while clicking on "Details" shows there warnings (being addressed in #20273). How is that?

@BillWagner BillWagner merged commit b9122d1 into live Aug 26, 2020
@BillWagner BillWagner deleted the publish-7154 branch August 26, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants