-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the subsections of §12.8.17, "The new operator" #1247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM @RexJaeschke
I'd like to wait to merge until our meeting next week in case others want to weigh in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, this makes a lot of sense.
@dotnet/ecma-tc49-tg2 please review offline. |
@BillWagner This PR is ready to merge once the following is resolved (which I don't know how to do): "Renumber standard TOC / renumber-sections (pull_request) failed" |
I think that once this is merged, running the tool will fix the issue. It's there because you renumbered all the sections that moved. (The tool tracks that and fixes them for you). But, because you didn't update the sections in the grammar annex (which is rewritten by the tool), those are flagged as a concern. |
@BillWagner As you just explained, I should not have updated manually all the old links. You will force-merge this and we'll see what happens. |
Agreed in meeting 2025/02/19: Bill will merge tomorrow, and cleanup any fallout for renumbering. |
AFter dotnet#1247 was merged, fixup section numbers by hand. I did run all the tools locally, as a test.
AFter #1247 was merged, fixup section numbers by hand. I did run all the tools locally, as a test.
[As we discussed, Bill, here are the changes needed.]
Regarding §12.8.17, "The new operator", we currently have the following section organization:
§12.8.17 The new operator
I'm refactoring this, as follows:
§12.8.17 The new operator
The rationale for this comes from §12.8.17.1, where we say,
There are three forms of new expressions:
So, I’ve simply rearranged the existing section list to reflect there are 3 categories instead of the 6 currently implied.
And I adjusted all the links to those sections.