Nullability: conversion behavior #1242
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnm2
commented
Jan 1, 2025
jnm2
commented
Jan 3, 2025
jskeet
added
the
meeting: discuss
RexJaeschke
removed
the
meeting: discuss
jnm2
force-pushed
the
nullability/conversions
branch
from
5ff046a to
da6c48d
Compare
jnm2
force-pushed
the
nullability/conversions
branch
from
da6c48d to
95a4f4e
Compare
jskeet
added
the
meeting: discuss
|
@BillWagner Would you like to take a look at these added nullability examples since you had been working on previous ones? |
BillWagner
approved these changes
Mar 21, 2025
jskeet
removed
the
meeting: discuss
|
Ii think you need to be looking for ^>.*\r\n> *\r\n in a block quote but not in a contained code block in the block quote (i.e. just be wary of false +ve’s). This sequence occurs at the start & end of this particular code block. As Bill mentions you can disable particular errors in a file, just add HTML comments:
Disable one or more rules by name: <!-- markdownlint-disable MD001 MD005 -->
Enable one or more rules by name: <!-- markdownlint-enable MD001 MD005 —>
… On 17/04/2025, at 10:56 am, Joseph Musser ***@***.***> wrote:
@jnm2 commented on this pull request.
In standard/types.md <#1242 (comment)>:
> +> {
+> public void M1(string p)
+> {
+> _ = (string?)p; // No warning, widening
+> }
+>
+> public void M2(string? p)
+> {
+> _ = (string)p; // Warning, narrowing
+> _ = (string)p!; // No warning, suppressed
+> }
+> }
+> ```
+>
+> *end example*
+
I might be misunderstanding. This seems to be rule https://github.com/DavidAnson/markdownlint/blob/v0.37.4/doc/md028.md. Scrolling through files and a regex search in all files for ^>.*\r\n\r\n> didn't turn anything up, so I haven't found any examples to follow.
Looking at what this rule is, it seems to be saving people from creating block quotes that get unified by some parsers and not others. If that's not a concern in this spot, then it seems that it must not be a concern for the entire repo, and maybe we could ignore MD028 globally with the run of this tool. What do you think?
—
Reply to this email directly, view it on GitHub <#1242 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABSYVW25CK5JCOPYYOQGUJ32Z3NZNAVCNFSM6AAAAABUOEA7CKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDONZUGA3DQOBTGA>.
You are receiving this because you were mentioned.
|
|
CI is nice and fast. Really neat system here! |
Nigel-Ecma
reviewed
Apr 17, 2025
| > | ||
| > public void M2(string? p) | ||
| > { | ||
| > _ = (string)p; // Warning, narrowing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe we jinxed it after all?
This is my first PR to the repo. Guidance is very helpful. Think of the lines of this PR as a series of questions: how far to go, whether it's worth going here, how do we do things?