Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat stackalloc like array creation. #1237

Open
wants to merge 1 commit into
base: draft-v8
Choose a base branch
from
Open

Conversation

gafter
Copy link
Member

@gafter gafter commented Dec 15, 2024

Fixes #1232

@gafter gafter added the meeting: discuss This issue should be discussed at the next TC49-TG2 meeting label Dec 15, 2024
@gafter gafter added this to the C# 8.0 milestone Dec 15, 2024
Copy link
Contributor

@Nigel-Ecma Nigel-Ecma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I have not reviewed the PR per se, just why it is failing grammar validation.

This PR will fail grammar validation as it changes a production that the validator itself alters to resolve MLR.

Before this PR can be committed a manual grammar validation will be required and the grammar validator updated (if the later is not done all future PRs will fail validation).

I’ll take responsibility for doing these, till then I'll block merging by checking “Request changes”.

Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is a good change, in terms of the grammar giving the right feeling for the difference. As Nigel has said, in a parallel universe we might have picked an entirely different approach, but I think this is the best change for where we are today.

@jskeet
Copy link
Contributor

jskeet commented Jan 22, 2025

(It sounds like @gafter has found more issues though...)

@RexJaeschke RexJaeschke removed the meeting: discuss This issue should be discussed at the next TC49-TG2 meeting label Jan 22, 2025
@Nigel-Ecma Nigel-Ecma self-assigned this Mar 14, 2025
@gafter
Copy link
Member Author

gafter commented Mar 19, 2025

No, not more issues. It is just the grammar validation.

@jskeet
Copy link
Contributor

jskeet commented Mar 20, 2025

Okay, so just to check, is the ball now in @Nigel-Ecma's court to validate the grammar and update the validator?

@Nigel-Ecma
Copy link
Contributor

Okay, so just to check, is the ball now in @Nigel-Ecma's court to validate the grammar and update the validator?

@jskeet – Essentially yes, my earlier comment provides details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prohibit stackalloc int[3][1]
4 participants