-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat stackalloc like array creation. #1237
base: draft-v8
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I have not reviewed the PR per se, just why it is failing grammar validation.
This PR will fail grammar validation as it changes a production that the validator itself alters to resolve MLR.
Before this PR can be committed a manual grammar validation will be required and the grammar validator updated (if the later is not done all future PRs will fail validation).
I’ll take responsibility for doing these, till then I'll block merging by checking “Request changes”.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is a good change, in terms of the grammar giving the right feeling for the difference. As Nigel has said, in a parallel universe we might have picked an entirely different approach, but I think this is the best change for where we are today.
(It sounds like @gafter has found more issues though...) |
No, not more issues. It is just the grammar validation. |
Okay, so just to check, is the ball now in @Nigel-Ecma's court to validate the grammar and update the validator? |
@jskeet – Essentially yes, my earlier comment provides details. |
Fixes #1232