Skip to content

Extensions: misc validation #9274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2025
Merged

Extensions: misc validation #9274

merged 3 commits into from
Apr 3, 2025

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Apr 2, 2025

No description provided.

The _receiver parameter_ is not allowed to have modifiers if it is unnamed, and
it is only allowed to have the refness modifiers listed below and `scoped` otherwise.
The _receiver parameter_ bears the same restrictions as the first parameter of a classic extension method.
The _receiver parameter_ may not have an `[EnumeratorCancellation]` attribute.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this disagrees with implementation

@AlekseyTs
Copy link
Contributor

Done with review pass (commit 2)

@jcouv jcouv requested a review from AlekseyTs April 2, 2025 16:41
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 3)

@jcouv jcouv merged commit b5a1c3e into dotnet:main Apr 3, 2025
1 check passed
@jcouv jcouv deleted the extensions-validation branch April 3, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants