Fix null reference exception in MvcFacts.GetDeclaringType #63593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves an issue where OverriddenMethod could be null during semantic classification in Visual Studio, causing a StreamJsonRpc.RemoteInvocationException. The fix simplifies the while loop condition to check for both IsOverride and OverriddenMethod != null in a single expression, preventing the null reference exception. Fixes dotnet#59736
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
|
Thanks for your PR, @@Nonanti. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
martincostello
added
area-mvc
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
dotnet-policy-service
bot
added
the
pending-ci-rerun
|
/azp run |
|
Commenter does not have sufficient privileges for PR 63593 in repo dotnet/aspnetcore |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 63593 in repo dotnet/aspnetcore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a null reference exception that occurs during semantic classification in Visual Studio when analyzing overridden methods.
Issue
Fixes #59736
Changes
GetDeclaringTypemethod to check bothIsOverrideandOverriddenMethod != nulltogetherOverriddenMethodpropertyTechnical Details
The original code would enter the loop when
method.IsOverridewas true, butOverriddenMethodcould still be null in certain edge cases. By combining both checks in the loop condition, we avoid the null reference exception entirely.Testing
Built the project locally and verified the change resolves the issue without breaking existing functionality.