-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Blazor - rendering metrics and tracing #61609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
pavelsavara
wants to merge
8
commits into
dotnet:main
Choose a base branch
from
pavelsavara:blazor_metrics_feedback
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
328a584
to
cebb68e
Compare
# Conflicts: # src/Components/Components/src/PublicAPI.Unshipped.txt
- add tracing
3 tasks
You're adding a lot of metrics here. I think you should do some performance testing. There is performance overhead of metrics - they require some synronization when incrementing counters and recording values. Having many low level metrics could cause performance issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better rendering metrics
aspnetcore.components.rendering.batch.duration
- Duration of rendering batch.aspnetcore.components.rendering.batch.exception
- Total number of exceptions during batch rendering.aspnetcore.components.rendering.diff.duration
- Duration of rendering component HTML diff.aspnetcore.components.event.asynchronous.duration
- Duration of processing browser event asynchronously.aspnetcore.components.event.synchronous.duration
- Duration of processing browser event synchronously.aspnetcore.components.parameters.asynchronous.duration
- Duration of processing component parameters asynchronously.aspnetcore.components.parameters.synchronous.duration
- Duration of processing component parameters synchronously.aspnetcore.components.navigation.count
- Total number of route changes.Blazor activity tracing
Microsoft.AspNetCore.Components.Rendering
Feedback
IMeterFactory
to be available in DITODO - Metrics need to be documented at https://learn.microsoft.com/en-us/aspnet/core/log-mon/metrics/built-in
Contributes to #53613
Contributes to #29846
Feedback for #61516