Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Kestrel's ParseHeaders throwing ArgumentOutOfRange exception #61316

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix for Kestrel's ParseHeaders throwing ArgumentOutOfRange exception #61316

wants to merge 2 commits into from
+22 −1

Conversation

WereWind1
Copy link

Fix for Kestrel's ParseHeaders throwing ArgumentOutOfRange exception

RejectRequestHandler no longer tries to look beyond the scope of the span

Description

Fixes #61245

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Apr 4, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Thanks for your PR, @@WereWind1. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 4, 2025
@WereWind1
Copy link
Author

Also can anybody tell me if this change would propagate to different versions of ASP like 8.0? Or should I submit a separate PR?

@WereWind1
Copy link
Author

@dotnet-policy-service agree

@martincostello
Copy link
Member

Also can anybody tell me if this change would propagate to different versions of ASP like 8.0? Or should I submit a separate PR?

If it meets the servicing bar, the team would manage porting the fix to the relevant branches post-merge.

@WereWind1 @gfoidl
Apply suggested refactoring
9430fbc 
Co-authored-by: Günther Foidl <[email protected]>
@WereWind1 WereWind1 requested a review from gfoidl April 4, 2025 10:48
@BrennanConroy
Copy link
Member

Also can anybody tell me if this change would propagate to different versions of ASP like 8.0? Or should I submit a separate PR?

Why do you think this should be backported? It just ends up getting logged as an ArgumentOutOfRange exception instead of a BadHttpRequestException.

halter73
halter73 approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and the test. It's always nice to get the fundamentals right.

However, I agree with Brennan that it's probably not worth spending our time backporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

@mgravell mgravell Awaiting requested review from mgravell mgravell is a code owner

@gfoidl gfoidl Awaiting requested review from gfoidl

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kestrel's ParseHeaders throws an ArgumentOutOfRange exception on certain headers
5 participants
@WereWind1 @martincostello @BrennanConroy @halter73 @gfoidl