Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating to the new solution file format - .slnx #61273

Merged
merged 2 commits into from
Apr 6, 2025
Merged

Migrating to the new solution file format - .slnx #61273

merged 2 commits into from
Apr 6, 2025
+1,320 −11,854

Conversation

mkArtakMSFT
Copy link
Member

Fixes #61269

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 2, 2025
@mkArtakMSFT
Copy link
Member Author

This took me ~15 minutes to do. Does anyone know of a reason for not taking this?

@wtgodbe
Copy link
Member

wtgodbe commented Apr 2, 2025

Seems like some tests would need to be changed - in general I don't have any objection to this, but I'd recommend checking w/ devs (maybe in ASP.NET chat) to see how people think this would impact their workflow (I don't use VS as much as most devs on the team)

@mkArtakMSFT
Copy link
Member Author

Ok, found one mistake with absolute paths in the converted .slnx files. Will fix that now and see where it brings us

@build-analysis build-analysis bot mentioned this pull request Apr 2, 2025
Open
3 tasks
@mkArtakMSFT mkArtakMSFT force-pushed the mkArtakMSFT/solution branch from 16bc909 to d5f66e8 Compare April 3, 2025 17:56
@mkArtakMSFT mkArtakMSFT marked this pull request as ready for review April 3, 2025 18:03
@mkArtakMSFT
Copy link
Member Author

Thanks for taking a look at this, @richardstanton!

@mkArtakMSFT mkArtakMSFT enabled auto-merge (squash) April 4, 2025 00:11
@mkArtakMSFT
Copy link
Member Author

@wtgodbe the failing tests are all flaky, so I think we should merge this one without waiting for the tests to pass. I have #61349 quarantining the OpenAPI tests and @lewing been notified to look into the failing components tests which aren't related to the changes in this PR.

@mkArtakMSFT mkArtakMSFT merged commit b4c1921 into main Apr 6, 2025
27 checks passed
@mkArtakMSFT mkArtakMSFT deleted the mkArtakMSFT/solution branch April 6, 2025 22:02
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview4 milestone Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

@richardstanton richardstanton richardstanton approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

@mgravell mgravell Awaiting requested review from mgravell mgravell is a code owner

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
10.0-preview4
Development

Successfully merging this pull request may close these issues.

Update the AspNetCore.sln solution to the new SLNX format
4 participants
@mkArtakMSFT @wtgodbe @halter73 @richardstanton