Skip to content

Adds state management and caching to AspireWithDapr Weather sample #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulyuk wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adds state management and caching to AspireWithDapr Weather sample #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3224631
added state management and ttl
Nov 14, 2023
cc58f23
created some constants for readability
Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion samples/AspireWithDapr/AspireWithDapr.Web/WeatherApiClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,34 @@
using Dapr.Client;


namespace AspireWithDapr.Web;


public class WeatherApiClient(DaprClient daprClient)
{
const string stateStore = "statestore";
const string stateTTL = "120";
const string apiAppId = "api";

public async Task<WeatherForecast[]> GetWeatherAsync()
{
return await daprClient.InvokeMethodAsync<WeatherForecast[]>(HttpMethod.Get, "api", "weatherforecast");

// Get the weather from the state store if it exists
var weatherData = await daprClient.GetStateAsync<WeatherForecast[]>(stateStore, "weather");
Copy link
Member

@eerhardt eerhardt Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This app also uses output caching at the UI layer. Does it make sense to use both? Should we remove the output caching and use this instead?

Copy link
Member

@DamianEdwards DamianEdwards Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good point. Technically they're caching at different levels (API response vs. full HTML response) so could still be argued it's valuable.

Copy link
Member

@davidfowl davidfowl Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MOAR Caching


if (weatherData is null)
{
// If it doesn't exist, get it from the weather service
weatherData = await daprClient.InvokeMethodAsync<WeatherForecast[]>(HttpMethod.Get, apiAppId, "weatherforecast");

await daprClient.SaveStateAsync(stateStore, "weather", weatherData, metadata: new Dictionary<string, string>() {
Copy link
Member

@DamianEdwards DamianEdwards Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the metadata parameter typed as Dictionary<string, string>? If so, we can simplify to use target-typed new here. If not, oh well 😄

{
"ttlInSeconds", stateTTL
}
});
}

return weatherData;
}
}

Expand Down