[5.1] Optimization: Use Environment.TickCount for SqlStatistics execution timing #3831

cheenamalhotra · 2025-12-05T20:18:48Z

Ports #3609 to release/5.1 branch

…iming (#3609)

Copilot

Pull request overview

This PR optimizes SQL execution timing statistics by replacing the DateTime-based timer with Environment.TickCount for measuring ExecutionTime. This change reduces overhead while maintaining accuracy for performance statistics. The PR ports optimization work from #3609 to the release/5.1 branch.

Key changes:

Replaced DateTime.UtcNow.ToFileTimeUtc() with Environment.TickCount for ExecutionTime measurements
Added wraparound-safe elapsed time calculation to handle TickCount rolling over every ~24.9 days
Removed unreliable timing comparison assertions that could fail due to timing precision differences

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
AdapterUtil.cs	Added `FastTimerCurrent()` to return Environment.TickCount and `CalculateTickCountElapsed()` to calculate elapsed time with wraparound handling
SqlStatistics.cs	Changed `_startExecutionTimestamp` to nullable long, updated ExecutionTime accumulation to use TickCount directly (already in milliseconds), removed TimerToMilliseconds conversion
TickCountElapsedTest.cs	New test file validating wraparound handling for TickCount elapsed time calculations
Microsoft.Data.SqlClient.Tests.csproj	Registered the new TickCountElapsedTest.cs test file
CopyAllFromReader.cs	Removed assertions comparing ConnectionTime/ExecutionTime/NetworkServerTime as these are no longer reliable with different timing mechanisms

src/Microsoft.Data.SqlClient/tests/FunctionalTests/TickCountElapsedTest.cs

src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/AdapterUtil.cs

…apsedTest.cs Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/AdapterUtil.cs

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

src/Microsoft.Data.SqlClient/tests/FunctionalTests/TickCountElapsedTest.cs

codecov · 2025-12-06T00:33:29Z

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.47%. Comparing base (cc5c81a) to head (90abd9d).

Files with missing lines	Patch %	Lines
...ient/src/Microsoft/Data/SqlClient/SqlStatistics.cs	77.77%	2 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           release/5.1    #3831      +/-   ##
===============================================
- Coverage        71.51%   71.47%   -0.05%     
===============================================
  Files              293      293              
  Lines            61928    61931       +3     
===============================================
- Hits             44289    44265      -24     
- Misses           17639    17666      +27

Flag	Coverage Δ
addons	`92.38% <ø> (ø)`
netcore	`75.00% <81.81%> (-0.03%)`	⬇️
netfx	`69.87% <81.81%> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

paulmedynski

I agree with Copilot.

priyankatiwari08 · 2025-12-10T08:52:37Z

This branch needs a merge with main to include the codeql.yml file required for CodeQL scanning. The file should be placed under .github/workflows, which is currently missing in this branch. I had a similar experience for one of my PR where merge was blocked with similar code scanning comment, adding the file enabled successful code scanning.

src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

src/Microsoft.Data.SqlClient/tests/FunctionalTests/TickCountElapsedTest.cs

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Copilot · 2025-12-11T21:43:44Z

src/Microsoft.Data.SqlClient/tests/FunctionalTests/TickCountElapsedTest.cs

+            var adpType = Assembly.GetAssembly(typeof(SqlConnection)).GetType("Microsoft.Data.Common.ADP", System.Reflection.BindingFlags.Static | System.Reflection.BindingFlags.NonPublic);
+            return (uint) adpType.GetMethod("CalculateTickCountElapsed", System.Reflection.BindingFlags.Static | System.Reflection.BindingFlags.NonPublic).Invoke(null, new object[] {startTick, endTick});


The BindingFlags usage is overly verbose with full qualification. After adding the using System.Reflection; directive, change System.Reflection.BindingFlags.Static | System.Reflection.BindingFlags.NonPublic to BindingFlags.Static | BindingFlags.NonPublic for consistency with other test files in this directory.

Optimization: Use Environment.TickCount for SqlStatistics execution t…

0d41347

…iming (#3609)

Copilot AI review requested due to automatic review settings December 5, 2025 20:18

cheenamalhotra requested a review from a team as a code owner December 5, 2025 20:18

cheenamalhotra added this to the 5.1.9 milestone Dec 5, 2025

Copilot started reviewing on behalf of cheenamalhotra December 5, 2025 20:19 View session

cheenamalhotra linked an issue Dec 5, 2025 that may be closed by this pull request

Backport SqlStatistics perf improvement to MDS v5.1 #3763

Open

Copilot AI reviewed Dec 5, 2025

View reviewed changes

src/Microsoft.Data.SqlClient/tests/FunctionalTests/TickCountElapsedTest.cs Outdated Show resolved Hide resolved

src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/AdapterUtil.cs Show resolved Hide resolved

Update src/Microsoft.Data.SqlClient/tests/FunctionalTests/TickCountEl…

3b42905

…apsedTest.cs Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings December 5, 2025 20:24

Copilot started reviewing on behalf of cheenamalhotra December 5, 2025 20:24 View session

Copilot AI reviewed Dec 5, 2025

View reviewed changes

src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/AdapterUtil.cs Show resolved Hide resolved

cheenamalhotra added 2 commits December 5, 2025 12:46

Fix namespace

0d58548

Fix compilation issue

1f4edde

Copilot AI review requested due to automatic review settings December 5, 2025 21:03

Copilot started reviewing on behalf of cheenamalhotra December 5, 2025 21:04 View session

Copilot AI reviewed Dec 5, 2025

View reviewed changes

src/Microsoft.Data.SqlClient/tests/FunctionalTests/TickCountElapsedTest.cs Outdated Show resolved Hide resolved

paulmedynski requested changes Dec 8, 2025

View reviewed changes

paulmedynski self-assigned this Dec 8, 2025

cheenamalhotra requested a review from paulmedynski December 9, 2025 20:55

priyankatiwari08 reviewed Dec 10, 2025

View reviewed changes

src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj Show resolved Hide resolved

Copilot AI review requested due to automatic review settings December 10, 2025 17:15

Copilot started reviewing on behalf of cheenamalhotra December 10, 2025 17:16 View session

Copilot AI reviewed Dec 10, 2025

View reviewed changes

paulmedynski requested changes Dec 10, 2025

View reviewed changes

src/Microsoft.Data.SqlClient/tests/FunctionalTests/TickCountElapsedTest.cs Outdated Show resolved Hide resolved

src/Microsoft.Data.SqlClient/tests/FunctionalTests/TickCountElapsedTest.cs Outdated Show resolved Hide resolved

Update test to use reflection

86fba26

cheenamalhotra force-pushed the dev/cheena/5.1-port-sqlstatisticsperf branch from 90abd9d to 86fba26 Compare December 11, 2025 18:24

paulmedynski previously approved these changes Dec 11, 2025

View reviewed changes

Fixes

886127f

Copilot AI review requested due to automatic review settings December 11, 2025 21:39

cheenamalhotra dismissed paulmedynski’s stale review via 886127f December 11, 2025 21:39

Copilot started reviewing on behalf of cheenamalhotra December 11, 2025 21:39 View session

Copilot AI reviewed Dec 11, 2025

View reviewed changes

		var adpType = Assembly.GetAssembly(typeof(SqlConnection)).GetType("Microsoft.Data.Common.ADP", System.Reflection.BindingFlags.Static \| System.Reflection.BindingFlags.NonPublic);
		return (uint) adpType.GetMethod("CalculateTickCountElapsed", System.Reflection.BindingFlags.Static \| System.Reflection.BindingFlags.NonPublic).Invoke(null, new object[] {startTick, endTick});

[5.1] Optimization: Use Environment.TickCount for SqlStatistics execution timing #3831

Are you sure you want to change the base?

[5.1] Optimization: Use Environment.TickCount for SqlStatistics execution timing #3831

Conversation

cheenamalhotra commented Dec 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

codecov bot commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

paulmedynski left a comment

Choose a reason for hiding this comment

Uh oh!

priyankatiwari08 commented Dec 10, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Dec 6, 2025 •

edited

Loading