Cleanup | Remove Abort/Doom From AsyncHelpers #3683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce and what made them different wasn't even utilized!
benrr101
added
the
Code Health 💊
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up the AsyncHelpers code by removing the no-longer-used connectionToDoom/connectionToAbort parameters that were previously needed for Constrained Execution Region (CER) code. The cleanup unifies netcore and netfx implementations and simplifies method signatures.
Key changes:
- Remove connectionToDoom and connectionToAbort parameters from AsyncHelper methods
- Clean up conditional compilation directives that are no longer needed
- Add named parameters to improve code readability
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| TdsParser.cs | Updated AsyncHelper calls to use named parameters and remove connectionToDoom parameter |
| SqlUtil.cs | Removed connectionToDoom/connectionToAbort parameters from AsyncHelper methods and cleaned up conditional compilation |
| SqlBulkCopy.cs | Updated AsyncHelper calls to use named parameters and remove connection parameters |
| TdsParserStateObject.netfx.cs | Removed conditional compilation for connectionToAbort parameter in AsyncHelper call |
paulmedynski
previously approved these changes
Oct 11, 2025
priyankatiwari08
previously approved these changes
Oct 13, 2025
benrr101
dismissed stale reviews from priyankatiwari08 and paulmedynski
via
40c730d
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3683 +/- ##
===========================================
+ Coverage 77.34% 90.82% +13.48%
===========================================
Files 271 6 -265
Lines 45245 316 -44929
===========================================
- Hits 34993 287 -34706
+ Misses 10252 29 -10223
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paulmedynski
approved these changes
Oct 16, 2025
mdaigle
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the rush to remove CER code (see #3535) I overlooked that some of the AsyncHelpers code became identical between netcore and netfx. As such, this PR cleans up that code to 1) unify netcore/netfx code for AsyncHelpers and 2) remove the no-longer-used connectionToDoom/connectionToAbort parameters to the AsyncHelpers.
Issues
N/A
Testing
Code continues to compile and will be validated by CI.