Improves Exception Message to show what part is missing. - #1971 #1974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twsouthwick
requested changes
Nov 21, 2025
| <IncludeFrameworkShims>true</IncludeFrameworkShims> | ||
| <TargetFrameworks>$(ProductTargetFrameworks)</TargetFrameworks> | ||
| </PropertyGroup> | ||
| <PropertyGroup> |
Member
There was a problem hiding this comment.
looks like just whitespace change? tabs/spaces?
| try | ||
| { | ||
| // TODO: should we delay load? | ||
| part = _openXmlPackage.Features.GetRequired<IPackageFeature>().Package.GetPart(uriTarget); |
Member
There was a problem hiding this comment.
Could we make the Getpart return null when there's this failure? Then we can just check for a null
twsouthwick
reviewed
Nov 25, 2025
| uriTarget.OriginalString, ex.Message); | ||
| throw new InvalidOperationException(errorMessage); | ||
| } | ||
| catch (Exception) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1971